check-va-api: Don't claim to have provided a reference frame
- Sep 07, 2023
-
-
Simon McVittie authored
In principle the context is a required parameter for vaCreateBuffer(), but in practice Mesa doesn't do anything with it, not even a validity check for it not being VA_INVALID_ID. Non-Mesa drivers, like the one from Intel and the unofficial one for Nvidia hardware via nvdec and cuda, do check for this. Thanks: Emil Velikov Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Sep 05, 2023
-
-
Simon McVittie authored
We're decoding a single frame, so there is no previous frame that we could possibly refer to; and our single frame is an i-frame (keyframe), so we don't need a reference anyway. When Mesa is compiled with assertions enabled, if num_ref_frames is greater than 0, it asserts that ReferenceFrames[0] up to ReferenceFrames[num_ref_frames-1] inclusive are valid handles to reference frames. In our case, that array is zero-filled, and 0 clearly can't be a valid handle to a previous frame because we don't have any previous frames at all, causing an assertion failure and crash. Closes: #117 Thanks: David Rosca Signed-off-by:
Simon McVittie <smcv@collabora.com>
-