Skip to content
Snippets Groups Projects

wrap: Send a more clear warning when attempting to bind /usr/* dirs

Merged Ludovico de Nittis requested to merge wip/usr_warning into master
All threads resolved!
  • glib-backports-internal: Backport g_warning_once from glib:

    This is useful when we want to log a warning message without spamming the same message over and over.

  • wrap: Send a more clear warning when attempting to bind /usr/* dirs:

    pressure-vessel doesn't support having the Steam Library under /usr.

    When this happens, pressure-vessel fails without a clear indication of what went wrong. For this reason we add a warning message to point out that pressure-vessel was asked to bind a directory that will not appear in the resulting container.

    Helps: https://github.com/ValveSoftware/steam-runtime/issues/288 Helps: #30 (moved)


I used g_warning_once because if the Steam Library is located under /usr/, multiple Steam environment variables will point to a path that starts with /usr/, e.g. STEAM_COMPAT_DATA_PATH, STEAM_COMPAT_INSTALL_PATH and STEAM_COMPAT_LIBRARY_PATHS. And then usually we attempt it twice, once for the setup phase and once for the actual game.

Edited by Ludovico de Nittis

Merge request reports

Merge request pipeline #11301 passed

Merge request pipeline passed for f02230ec

Approved by

Merged by Ludovico de NittisLudovico de Nittis 3 years ago (Apr 6, 2021 12:24pm UTC)

Merge details

  • Changes merged into master with 1297ff95.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #11303 passed

Pipeline passed for 1297ff95 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon McVittie approved this merge request

    approved this merge request

  • Approved with or without the suggested change.

  • added 1 commit

    • f02230ec - wrap: Send a more clear warning when attempting to bind /usr/* dirs

    Compare with previous version

  • Ludovico de Nittis resolved all threads

    resolved all threads

  • Ludovico de Nittis enabled an automatic merge when the pipeline for f02230ec succeeds

    enabled an automatic merge when the pipeline for f02230ec succeeds

  • mentioned in commit 1297ff95

  • Please register or sign in to reply
    Loading