Skip to content
Snippets Groups Projects
Commit f02230ec authored by Ludovico de Nittis's avatar Ludovico de Nittis
Browse files

wrap: Send a more clear warning when attempting to bind /usr/* dirs

pressure-vessel doesn't support having the Steam Library under `/usr`.

When this happens, pressure-vessel fails without a clear indication of
what went wrong. For this reason we add a warning message to point out
that pressure-vessel was asked to bind a directory that will not appear
in the resulting container.

Helps: https://github.com/ValveSoftware/steam-runtime/issues/288


Helps: #30

Signed-off-by: default avatarLudovico de Nittis <ludovico.denittis@collabora.com>
parent b0d283e4
No related branches found
No related tags found
1 merge request!284wrap: Send a more clear warning when attempting to bind /usr/* dirs
Pipeline #11301 passed
......@@ -381,6 +381,9 @@ bind_and_propagate_from_environ (FlatpakExports *exports,
canon = g_canonicalize_filename (values[i], NULL);
value_host = pv_current_namespace_path_to_host_path (canon);
if (flatpak_has_path_prefix (canon, "/usr"))
g_warning_once ("Binding directories that are located under \"/usr/\" is not supported!");
g_info ("Bind-mounting %s=\"%s%s%s\" from the current env as %s=\"%s%s%s\" in the host",
variable, before, values[i], after,
variable, before, value_host, after);
......@@ -2374,6 +2377,9 @@ main (int argc,
g_assert (g_path_is_absolute (opt_filesystems[i]));
g_info ("Bind-mounting \"%s\"", opt_filesystems[i]);
if (flatpak_has_path_prefix (opt_filesystems[i], "/usr"))
g_warning_once ("Binding directories that are located under \"/usr/\" "
"is not supported!");
flatpak_exports_add_path_expose (exports,
FLATPAK_FILESYSTEM_MODE_READ_WRITE,
opt_filesystems[i]);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment