Fix PulseAudio-related regressions
-
pv-wrap: Don't crash with Flatpak subsandbox
Fixes: 1b720eb7 "wrap: Set PulseAudio as the default ALSA driver if available"
-
pv-wrap: Configure PulseAudio as default in /etc/asound.conf
This fixes two separate issues:
- It's parsed by all known versions of libasound.so.2, so it will work for both Steam Runtime 1 'scout' and Steam Runtime 2 'soldier', as well as future runtimes. Previously, we were using a path that only works in runtimes newer than scout.
- It's a direct child of /etc, which in our case is a tmpfs, so we don't need to worry about whether we will be able to create a mount point in a subdirectory.
Fixes: 1b720eb7 "wrap: Set PulseAudio as the default ALSA driver if available"
-
pv-runtime: Move PulseAudio setup into PvRuntime
-
pv-runtime: Configure libasound.so.2 in Flatpak subsandbox too
Verified to fix a soldier regression caused by !269 (merged) (soldier container not starting), and verified to fix scout's and soldier's ability to play audio through PulseAudio with the aplay
binary.
Also verified to create /etc/asound.conf
in a Flatpak subsandbox, when combined with !276 (merged) to make launching the subsandbox work.
/cc @denittis
Merge request reports
Activity
added Bug Regression ~37 labels
added Release blocker label
added To Test label
- Resolved by Ludovico de Nittis
Oh I'm sorry about !269 (merged) that was far from being bug-free.
This patch looks good to me, but I'll do a quick test myself too and I'll let you know if something doesn't work as expected.
mentioned in commit adc3e183