Skip to content
Snippets Groups Projects

wrap: Put game-specific $HOME on bwrap command-line before exports

Merged Simon McVittie requested to merge wip/issue63 into master
  • wrap: Put game-specific $HOME on bwrap command-line before exports

    This is how Flatpak behaves, and it's necessary to prevent the game-specific $HOME from being mounted over the top of some of the exports, preventing (for example) ~/.steam from being exposed to the container.

    We only do this for $HOME rather than completely reverting 3a8e939d, so that it won't be a regression for a symlink at /var/tmp.

    If the logical and physical paths to the real $HOME differ, we now also mount the game-specific $HOME onto the real $HOME's physical path, and replicate the logical path's symlinks in the container. This matches how Flatpak works, and avoids a similar regression.

    Fixes: 3a8e939d "pv-wrap: Delay --dir, etc. until after FlatpakExports are processed" Resolves: https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/issues/63

Edited by Simon McVittie

Merge request reports

Merge request pipeline #10138 passed

Merge request pipeline passed for 242e8906

Merged by Ludovico de NittisLudovico de Nittis 4 years ago (Mar 12, 2021 3:48pm UTC)

Loading

Pipeline #10142 passed

Pipeline passed for f48c4d0d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading