wrap: execute nvidia-modprobe before entering the container
Fixes: #59 (closed)
Note that with the current PRESSURE_VESSEL_RELAUNCH_CONTAINER
option, if nvidia-modprobe
doesn't succeed, we probably end up trying to run it two times (one for the setup and one for the actual game). The only real side effect of this should be a double cannot run nvidia-modprobe
message in the log.
I implemented this following the discussion on #59 (closed) but I didn't actually test this patch because I don't have a system with a Nvidia GPU.
Merge request reports
Activity
- Resolved by Ludovico de Nittis
- Resolved by Ludovico de Nittis
- Resolved by Ludovico de Nittis
- Resolved by Ludovico de Nittis
- Resolved by Simon McVittie
I implemented this following the discussion on #59 (closed) but I didn't actually test this patch because I don't have a system with a Nvidia GPU.
Please could you do a manual test by locally hacking the check to look at
/sys/module/bluetooth/version
(or some other module with aversion
that you do have) instead of/sys/module/nvidia/version
, and adding a stubmodprobe
to yourPATH
?Edited by Simon McVittie
added 35 commits
-
2061a644...630a52f7 - 32 commits from branch
master
- e5fafaf2 - wrap: execute nvidia-modprobe before entering the container
- 723f6016 - utils: refactor pv_capture_output into a more generic pv_run_sync
- 56402aca - wrap: execute nvidia-modprobe before entering the container
Toggle commit list-
2061a644...630a52f7 - 32 commits from branch
- Resolved by Ludovico de Nittis
206 212 NULL, NULL, 207 213 &output, 208 214 &errors, 209 &wait_status, 215 &exit_status, No, this is still a wait status. This was wrong in
pv_bwrap_run_sync()
and correct inpv_capture_output()
.The
(out)
parameter ofwait()
andwaitpid()
gives you a wait status, and then you decode the wait status into either an exit status ifWIFEXITED
, a terminating signal ifWIFSIGNALED
, or some mysterious other thing.Implementation detail: on Linux, and I think every other known Unix OS, the wait status is:
bit# | 31 ... 24 | 23 ... 16 | 15 ... 8 | 7 | 6 ... 0 | -----|-----------|-----------|-------------|-------------| | unused | unused | exit status | C | signal |
where C is 1 if the process dumped core.
changed this line in version 4 of the diff
enabled an automatic merge when the pipeline for b898cdd3 succeeds
mentioned in commit 9533e588