runtime: Set LD_LIBRARY_PATH before using capsule-capture-libs
At this stage we expect to have LD_LIBRARY_PATH
set to the
SYSTEM_LD_LIBRARY_PATH
of steam.sh
.
This means that we should treat the LD_LIBRARY_PATH
entries as
OS-level search path too.
/cc @smcv
Merge request reports
Activity
I opened this MR too early, still nothing to see here. Come back later :)Edited by Ludovico de Nittisadded 1 commit
- 0b37abe9 - runtime: Set LD_LIBRARY_PATH before using capsule-capture-libs
For a bit more of context:
pressure-vessel-unruntime unsets
LD_LIBRARY_PATH
, setsLD_LIBRARY_PATH=$SYSTEM_LD_LIBRARY_PATH
and then calls p-v wrap.This means that if Steam is launched as
LD_LIBRARY_PATH=/my_path:${LD_LIBRARY_PATH} steam
, in pressure-vessel we will correctly see LDLP set to/my_path
.Instead if it is a game launch option set as
LD_LIBRARY_PATH="/my_path2:${LD_LIBRARY_PATH}" %command%
, in pressure-vessel, LDLP will not have/my_path2
(because the system's LDLP will be used). To support a custom LDLP from the game launch options we also need https://gitlab.steamos.cloud/steam/steamlinuxruntime/-/merge_requests/19Edited by Ludovico de Nittisadded 9 commits
-
0b37abe9...29ef73a5 - 8 commits from branch
master
- 1f74a2d8 - runtime: Set LD_LIBRARY_PATH before using capsule-capture-libs
-
0b37abe9...29ef73a5 - 8 commits from branch
- Resolved by Ludovico de Nittis
To support a custom LDLP from the game launch options we also need https://gitlab.steamos.cloud/steam/steamlinuxruntime/-/merge_requests/19
I think it is correct to handle this independently anyway. It's less certain that this is even what we want.
- Resolved by Simon McVittie
mentioned in commit 595b129a