- Jan 23, 2024
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
SteamLinuxRuntime_sniper.sh improvements See merge request !648
-
Simon McVittie authored
steamwebhelper will use this to keep using the steam-runtime-sniper.* names. Helps: steamrt/tasks#375 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
steamwebhelper will use this to keep using the steam-runtime-sniper.tar.xz name. Helps: steamrt/tasks#375 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This will make it easier to put locking around the unpacking step, avoiding the possibility of concurrent unpacking by more than one process, which would corrupt the runtime directory. Helps: steamrt/tasks#385 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This avoids corrupting machine-readable output on stdout, if any. Helps: steamrt/tasks#385 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
steamrt/tasks#375 See !643
-
- Jan 19, 2024
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
scout-on-soldier: Cope with restructuring in yesterday's Steam client beta See merge request !647
-
Simon McVittie authored
Beta 1705630720 changed the filename of the checksum used for the scout tarball, as part of distributing the scout tarball as a single file rather than multiple parts. steamrt/tasks#382 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jan 15, 2024
-
-
Ludovico de Nittis authored
Add missing newline to some error messages See merge request !644
-
- Jan 12, 2024
-
-
Simon McVittie authored
This allows for standalone use of SLR from a small number of files including a compressed tarball, which is more convenient in some use-cases (although less disk-space-efficient than Steampipe). Usage: * put SteamLinuxRuntime_sniper.sh in a directory * put SteamLinuxRuntime_sniper.tar.xz in the same directory * put SteamLinuxRuntime_sniper.VERSIONS.txt in the same directory * run, e.g., /path/to/SteamLinuxRuntime_sniper.sh -- xterm @RUNTIME@ is replaced by a string identifying the specific SLR version we are working with, which in practice would be SteamLinuxRuntime_sniper. Future runtime versions should switch to using SteamLinuxRuntime_4 or similar. Instead of requiring a sidecar file with a MD5 checksum of the archive like we do for scout and heavy, we now rely on the archive itself having reasonable detection of accidental modification (a CRC or similar), and use VERSIONS.txt as the check for whether our unpacked directory is the version we wanted to be using. MD5 is no longer considered to be a cryptographically strong hash, so it would not be sufficient for detecting malicious modification in any case. As an additional integrity check, if run with the --validate option, the wrapper script will run pv-verify. This is not particularly fast (around 20 seconds on HDD with a cold cache, around 3 seconds with warm cache). As an optimization, if the script is run with for example /path/to/SteamLinuxRuntime_sniper.sh \ --try-runtime=/path/to/steamapps/common/SteamLinuxRuntime_sniper \ -- xterm then it will check whether the path passed to --try-runtime has the desired version number (there is no validation beyond a simple comparison of VERSIONS.txt). If yes, it will use that instead of unpacking a new copy, saving around 700M in the case of sniper. Compared with the prototype provided in steamrt/tasks#375, this one is somewhat more defensively-coded, with "|| true" on commands where we can tolerate failure (inspecting compressed files, running zenity) in an attempt to make it maximally robust. Helps: steamrt/tasks#375, steamrt/tasks#376 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This is a more direct form of what we want in the depot than steam-container-runtime.tar.gz. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This makes the generated depot self-contained, without needing to rely on the depot being written to a directory named `depot` with a copy of `subprojects/container-runtime/steampipe` next to it. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This was supported in Python 3.6, which is our minimum version, and we already used PEP-526 syntax in some places. The Python-3.5-compatible "# type: Type" comments result in "unused import" warnings with recent pyflakes versions, which are avoided by this change. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
pv-adverb: Describe target of each redirection See merge request !642
-
Simon McVittie authored
The g_log() family (g_warning() and friends) and launcher-interface-0's trace() automatically add a newline, but fprintf() does not. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Helps: steamrt/tasks#370 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jan 05, 2024
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jan 04, 2024
-
-
Ludovico de Nittis authored
pv-wrap: Remove an unused variable See merge request !641
-
- Jan 03, 2024
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 14, 2023
-
-
Simon McVittie authored
pv-wrap: Don't register stdout, stderr, --pass-fd with FlatpakBwrap See merge request !640
-
Simon McVittie authored
This fixes two separate issues. If we add a file descriptor to the FlatpakBwrap object with flatpak_bwrap_add_fd, then flatpak_bwrap_child_setup() will lseek() back to byte 0 before it execs the replacement process. This is often what we want - for example, when we have written out a file containing the container identification, we want any subsequent read from that file to start at byte 0. However, it is absolutely not what we want if stdout/stderr are directed to a log file, in which case any writes after the lseek() will start from the beginning and overwrite the content of the log file. The symptom for this is that debug messages from pv-adverb start at the beginning of the log file, overwriting earlier debug messages from pv-wrap (but directing the log to a pipe or to the systemd Journal works fine, because those aren't seekable). Similarly, if --pass-fd is being used for a seekable file, we probably don't want to force it to seek back to byte 0. The second issue is that adding a fd with flatpak_bwrap_add_fd() means the FlatpakBwrap object takes responsibility for closing that fd. This was incorrect to do for original_stdout and original_stderr without transferring ownership (which we don't want to do), because they are declared with glnx_autofd, meaning that they will be closed automatically when they go out of scope. In the error code path where pv_bwrap_execve() fails, this means they will be closed twice - once by glnx_autofd, and once by the g_autoptr(FlatpakBwrap) - leading to an assertion failure. This is mitigated by not being a problem in the success code path where pv_bwrap_execve() succeeds, which in practice is the one we always want to reach. Avoid both of these by using a separate list of fds to inherit, not seeking back to the beginning of those, and not closing them. This has the side-effect that fds from --pass-fd are also not closed, but that seems harmless, and arguably more correct: they're open on entry to main(), and they're still open on exit from main(), so no change of ownership has happened. steamrt/tasks#370 Fixes: 779d13fd "pv-wrap: Let pv-adverb restore our original stdout/stderr" Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 13, 2023
-
-
Simon McVittie authored
We no longer append any items to this array under any circumstances, so iteration will not do anything useful. Fixes: f4f25f4b "pv-wrap: Remove support for escaping from a Flatpak container" Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 08, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
populate-depot: Remove all DRI plugins from legacy-free SLR branches See merge request !638
-