Skip to content

Fix check-vulkan when installed to final location

Simon McVittie requested to merge wip/smcv/fix-check-vulkan into master

While working on !71 (closed) I accidentally found that check-vulkan does not work when doing "end-to-end" testing, only when run manually.

  • Look for -check-vulkan in default helpers path, not in PATH

    -check-vulkan is provided by steam-runtime-tools itself, in /usr/libexec/steam-runtime-tools-0, and not by some other package in /usr/bin; so if the caller has not overridden the helpers path at the SrtSystemInfo level, we must look for it in the default helpers path.

    This bug was hidden by the fact that the unit tests do override the helpers path, in order to find our mock versions of wflinfo and vulkaninfo.

  • check-vulkan: Don't assume SRT_DATA_PATH ends with a slash

  • check-vulkan: Look for shaders in the correct place when installed

    We install them in /usr/libexec/steam-runtime-tools-0/shaders, not in /usr/libexec/steam-runtime-tools-0.

  • d/rules: Replace mock helpers with symlinks to *-true if identical

    This avoids them having identical detached debug symbols in different binary packages, which cannot be co-installed.

/cc @jpwhiting @denittis

Merge request reports