Skip to content

Remove --runtime-archive and other unused code paths

Simon McVittie requested to merge wip/smcv/cleanup into main

  • !658 (merged)

  • pv-runtime: Stop cleaning up pre-2021 unpack directories

    Before we added SteamLinuxRuntime_whatever/var in early 2021, we would unpack runtime archives directly into SteamLinuxRuntime_whatever/scout_0.x or similar. Assume that all such directories have been cleaned up by now.

  • container-runtime: Remove support for shipping the runtime as an archive

    We haven't done this since May 2021, and for the copy used for the steamwebhelper since January 2024, we are unpacking SteamLinuxRuntime_sniper.tar.xz (including pressure-vessel) in preference to using pv-wrap --runtime-archive. I think we can conclude that we will not use that mode in future, either.

  • launch-options: Remove support for unpacking runtimes from an archive

    In preparation for removing it from pv-runtime altogether.

  • tests: Stop testing --runtime-archive, --runtime-id

    We haven't done this in production since May 2021.

  • pv-runtime: Stop supporting --runtime-archive, --runtime-id

    We haven't done this since May 2021, and for the copy of SLR_sniper used for the steamwebhelper since January 2024, we are unpacking SteamLinuxRuntime_sniper.tar.xz (including pressure-vessel) in preference to using pv-wrap --runtime-archive.

  • pv-runtime: Stop cleaning up temporary deploy-* directories

    In practice we stopped creating these in mid 2021, when we stopped shipping runtimes as an archive. Now that the code to unpack archives has gone entirely, so can this.

  • container-runtime: Remove --include-sdk-debug, --include-sdk-runtime

    --include-sdk-sysroot stays, for now, because we use it in build-aux/many-builds.py.

  • container-runtime: Remove support for not minimizing depot content

    When we distribute complete runtime content via Steampipe, in practice it is always going to be most robust if we remove filesystem objects that it is known not to preserve well, like symlinks and empty directories.

  • container-runtime: Re-indent populate-depot.py

    Previous refactoring has left it with an if True: block and a trivial for loop. Clean those up.

Edited by Simon McVittie

Merge request reports