Skip to content
Snippets Groups Projects

pv-wrap: Fix minor issues caught by the test suite

Merged Simon McVittie requested to merge wip/smcv/misc-fixes into main

Minor fixes from initial work on steamrt/tasks#349, continuing from !633 (merged).


  • !633 (merged)

  • pv-runtime: Combine assorted booleans into a bitfield

    No functional change intended, it just uses a little less memory.

  • check-xdg-portal: Allocate and free one GVariant per loop iteration

    Previously we allocated one GVariant per loop, but only freed the last. When building with AddressSanitizer, this caused a crash which is reported to systemd-coredump if used (but the JSON output was valid, and the test suite can't assert that check-xdg-portal succeeds because on some test systems it might not, so the crash did not cause a test failure).

  • helpers: Disable leak sanitizer for wflinfo

    There appears to be a once-per-process memory leak in wegl_display_init(), which is uninteresting for a short-lived process.

  • wflinfo: Mostly resync with waffle 1.8.0

    No functional changes. The vast majority of our delta was merged: our only remaining changes are to use a slightly older WAFFLE_API_VERSION, and apply https://gitlab.freedesktop.org/mesa/waffle/-/merge_requests/146 as local delta.

Merge request reports

Pipeline #68306 passed

Pipeline passed for cd18a3fd on wip/smcv/misc-fixes

Approved by

Merged by Ludovico de NittisLudovico de Nittis 1 year ago (Nov 24, 2023 9:43am UTC)

Merge details

  • Changes merged into main with e80e4443.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading