Skip to content

Minor fixes prompted by !604

Simon McVittie requested to merge wip/smcv/task342-pre into main

Follow-up for !600 (merged), with enablers for !604 (merged).

As usual, best reviewed commit-by-commit.

  • pv-runtime: Log a warning if we can't set up /etc/timezone

    Historically we completely ignored errors here, so it's possible that there are valid scenarios where this fails; just log a warning instead of stopping the whole runtime setup.

  • pv-runtime: /usr in the container is not (directly) mutable

    In practice we never call path_mutable_in_container_namespace() for paths below /usr, because its only caller is pv_runtime_make_symlink_in_container() which has a special case for /usr.

    /usr is certainly not directly modifiable, other than by having a mutable sysroot that is special-cased to be modified in-place.

  • pv-wrap: graphics_provider_mount_point can be local and const

    Trivial refactoring, no functional change other than saving some g_strdup() (and the resulting strings were never freed).

  • pv-wrap: Move pv_bwrap_append_adjusted_exports() to bwrap.c

    No functional change, just reducing the size of wrap.c a bit.

Merge request reports