Skip to content
Snippets Groups Projects

Fix interop with older Upstart- and sysvinit-based OSs

Merged Simon McVittie requested to merge wip/smcv/runshm into master
All threads resolved!

While testing steamlinuxruntime!49 (merged) I noticed we had lost interoperability with Ubuntu 14.04.

  • bwrap: Don't explicitly mount /dev/pts, /dev/shm

    bubblewrap mounts filesystems recursively, so mounting /dev is enough, unless /dev/shm is a symbolic link (which will be handled in a subsequent commit). /dev/pts is assumed not to be a symbolic link: there would be no reason to do so.

  • bwrap: Cope with /dev/shm being a symlink to /run/shm

    This can be the case on older sysvinit- or Upstart-based Debian-derived distributions, such as Ubuntu 14.04 (with the default Upstart init system) and Debian 9 (with the non-default sysvinit init system).

    Under systemd or the versions of sysvinit in Debian >= 10, /dev/shm is a real tmpfs and /run/shm is a symlink to /dev/shm.

Merge request reports

Pipeline #14356 passed

Pipeline passed for 738be4c6 on wip/smcv/runshm

Approved by

Merged by Ludovico de NittisLudovico de Nittis 3 years ago (Jun 17, 2021 2:45pm UTC)

Merge details

  • Changes merged into master with 183124bc.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon McVittie added 1 commit

    added 1 commit

    • 738be4c6 - bwrap: Cope with /dev/shm being a symlink to /run/shm

    Compare with previous version

  • Simon McVittie resolved all threads

    resolved all threads

  • Ludovico de Nittis approved this merge request

    approved this merge request

  • Ludovico de Nittis enabled an automatic merge when the pipeline for 738be4c6 succeeds

    enabled an automatic merge when the pipeline for 738be4c6 succeeds

  • mentioned in commit 183124bc

  • Please register or sign in to reply
    Loading