Skip to content
Snippets Groups Projects

build: Use configuration_data instead of manual compiler flags

Merged Ludovico de Nittis requested to merge wip/config_file into master

Meson's configuration_data() allows us to generate a configuration file instead of manually passing each options as compiler flags.

With this commit we align steam-runtime-tools with pressure-vessel that already used a config.h.in file.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • VScode IntelliSense apparently gets really confused with manually defined compiler flags.

    It reports _SRT_MULTIARCH as an error saying in the hover text (notice the missing quotes):

    #define _SRT_MULTIARCH x86_64-linux-gnu
    Expands to:
    x86_64-linux-gnu
    identifier "x86_64" is undefined

    Instead using the config.h.in file everything works as expected:

    #define _SRT_MULTIARCH "x86_64-linux-gnu"
    Expands to:
    "x86_64-linux-gnu"

    So, with the excuse of aligning it with pressure-vessel this also fixes this issue on my end :)

    Edited by Ludovico de Nittis
  • Simon McVittie mentioned in commit c640195b

    mentioned in commit c640195b

Please register or sign in to reply
Loading