Skip to content

WIP: fixes for inspect-library

Simon McVittie requested to merge wip/smcv/inspect-library into wip/denittis/inspect-library

  • gitlab-ci: Ensure that libjson-glib-dev is installed

    (Should probably be squashed into your commit)

  • inspect-library: Add minimal handling for out-of-memory

    (Should probably be squashed into your commit)

  • tests/library: Avoid g_autoptr

    We're targeting an Ubuntu 12.04-based system, which is why we can't have nice things.

    (Should probably be squashed into your commit)

  • tests/library: Include <string.h>, for strstr

    (Should probably be squashed into your commit)

  • build: Allow C99 constructs

    It's 20 years old and we aren't targeting MSVC, so we can have some nice things.

    (Obsoleted by !17 (merged))

  • build: Disable -Wunused-local-typedefs

    In older versions of GLib, G_STATIC_ASSERT triggers this.

    (Obsoleted by !18 (merged))

  • tests/library: Use plain Unix close()

    Older GLib didn't have g_close().

    (Should probably be squashed into your commit)

  • library: Use json_node_free instead of json_node_unref

    Older versions of json-glib didn't have this.

    (Should probably be squashed into your commit)

  • library: Don't use json_from_string() convenience API

    This was only introduced in 1.2.x, which I don't want to backport to scout right now.

    (I wrote this by referring to the documentation rather than pasting it in from json-glib, so it doesn't affect our licensing.)

    (Should probably be squashed into your commit)

  • build: Relax json-glib dependency to 1.0.x

    (Should probably be squashed into your commit)

  • utils: Ensure that g_type_init() gets called

    In GLib < 2.36, this wasn't automatic.

    The constructor has been backported into the SteamRT 1 'scout' version of GLib, but if you have an environment with more Ubuntu 12.04 apt sources available (like the official SDK schroot from setup_chroot.sh), they might override the SteamRT-patched version.

    (Obsoleted by !16 (merged))

Temporarily use my json-glib OBS branch for CI

We need a newer json-glib version that hasn't shipped in scout yet.

(This needs removing from the branch before it's merged.)
Edited by Simon McVittie

Merge request reports