Skip to content
Snippets Groups Projects
  1. Jul 31, 2017
  2. Jun 14, 2017
    • Colin Walters's avatar
      Add G_IN_SET, patch our internal users via spatch · 9a1b77ef
      Colin Walters authored
      I originally tried to get this into GLib:
      https://bugzilla.gnome.org/show_bug.cgi?id=783751
      
      But that looks like it's going to fail due to MSVC. Let's add it here at least
      so I can start using it tomorrow and not wait for the MSVC team to catch up.
      
      I renamed `glnx-alloca.h` to `glnx-macros.h` as a more natural collective
      home for things from systemd's `macro.h`.
      
      Finally, I used a Coccinelle spatch similar to the one referenced
      in the above BZ to patch our uses.
      9a1b77ef
  3. May 30, 2017
  4. Jan 29, 2017
    • Colin Walters's avatar
      xattrs: Handle ERANGE · 7be21dee
      Colin Walters authored
      This is symmetric with an earlier commit which handled a transition from
      `size != 0` -> `size = 0`. Now if xattrs are added we retry.
      7be21dee
    • Colin Walters's avatar
      xattrs: Dedup fd reading code · 1ac35488
      Colin Walters authored
      By taking both fd and path into one copy of the reader func, exactly like we do
      in `read_xattr_name_array`, we can abstract over the difference.
      
      Preparatory cleanup for more work here.
      1ac35488
    • Colin Walters's avatar
      xattrs: Handle xattrs changing size concurrently · afd178fb
      Colin Walters authored
      We should be robust in the face of this and return a snapshot of the current
      value we saw, not transiently fail. This is the semantics we expect with ostree
      upgrades for `/etc` for example.
      afd178fb
    • William Manley's avatar
      listxattr: Don't assume that first call to listxattr gives correct size · 6bf55255
      William Manley authored
      To get the right sized buffer to pass to `flistattr` and `llistattr` we
      first call them with a zero byte buffer.  They then return the number of
      bytes they'll actually need to operate.  We would `malloc` and then call
      again assuming that the size we got originally was correct.
      
      On my computer at least this isn't always the case.  I've seen instances
      where the first call returns 23B, but then on the second one returns no
      data at all.  Getting these non-existant xattrs would then cause ostree
      to fail.
      
      I'm not sure why it's behaving this way on my machine.  I suspect its some
      interaction with overlayfs but I haven't proven this.
      6bf55255
  5. Feb 20, 2015
  6. Feb 15, 2015
Loading