- Dec 05, 2022
-
-
Simon McVittie authored
steamrt/tasks#212 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 02, 2022
-
-
Simon McVittie authored
The steam-ci-pipeline module is used for generic .deb packages in the Steam Runtime, but the steam-runtime-tools build process is sufficiently full of special cases that it actually seems simpler to give it completely independent CI. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
git-subtree-dir: subprojects/container-runtime git-subtree-mainline: e8de4b15 git-subtree-split: cc4e44f0
-
- Nov 30, 2022
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Nov 28, 2022
-
-
Ludovico de Nittis authored
pv-runtime: Log more details about how we change the mutable sysroot See merge request !526
-
Ludovico de Nittis authored
pv-runtime: Optionally log /overrides or full container contents See merge request !506
-
- Nov 24, 2022
-
-
Simon McVittie authored
Logging the contents of `/overrides` enlarges the log by around 10% (on a Debian 12 system) which we could consider doing by default, but for now I've made it an opt-in. Logging the entire contents of the container to be used is more like a 300% increase, so it certainly needs to be an opt-in that we ask for if it is genuinely going to be useful. Helps: steamrt/tasks#187, #97 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Helps: steamrt/tasks#187, #97 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Update Flatpak-derived code from Flatpak 1.14.1 See merge request !524
-
Simon McVittie authored
Prepare to update Flatpak-derived code See merge request !523
-
Simon McVittie authored
The majority of the changes are in code that is `#if 0` because it isn't needed in pressure-vessel. Changes that are not `#if 0` or trivial: * don't bind-mount `/efi` into containers, same as `/boot` * slightly better debug if a mkdir() fails in flatpak_context_export() * instead of deleting code that Flatpak needs but we don't, `#if 0` it, to make future merges simpler * use a better XML DOCTYPE for `fonts.conf` Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Flatpak 1.14.x assumes a version of bubblewrap that supports the --perms option. If our Flatpak-derived code produces an arguments list that includes that option, filter it out if we're using a system copy of bubblewrap that doesn't support it: it's non-essential. As of 1.12.7 (last time we updated our copy) and 1.14.1 (current stable release), none of the code paths we actually take from Flatpak make use of --perms, but they legitimately could. A manual test for whether this is working correctly: - Insert `"--perms", "0700"` before `"--tmpfs", "/tmp/.X11-unix"` in flatpak_run_add_x11_args() - Run the test suite with `build-aux/many-builds.py test` (for simplicity, do this on a system where the bundled bubblewrap can be used). Expected result: the log for containers.py indicates that the final bwrap command has `--perms 0700 --tmpfs /tmp/.X11-unix`. - Edit the check in test_bwrap_executable() so detection fails, by replacing `"--perms"` with `"--UNSUPPORTED-perms"`. - Run the test suite again. Expected result: we log `Ignoring "--perms 0700" because bwrap is too old` and later, the log indicates that the final bwrap command only has `--tmpfs /tmp/.X11-unix`. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
With this version, we no longer define FlatpakHostCommandFlags in launch-client (and in fact it would be an error). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Nov 21, 2022
-
-
Simon McVittie authored
Reviewed-by: Ludovico de Nittis Merge-request: !518 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Fixes: 516b106c "log: Add Journal integration to GLib log handler" Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Further logging improvements See merge request !521
-
Simon McVittie authored
Adding annotations to these functions means mypy will attempt to analyze them. It doesn't have particularly good information for PyGI code, but something is better than nothing. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Nov 17, 2022
-
-
Simon McVittie authored
This redirects output produced by pv-wrap, but puts back the original stdout/stderr for the wrapped program (typically the actual game). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This redirects output produced by pv-adverb, but puts back the original stdout/stderr for the wrapped program (typically the actual game). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This has three main functions: - If stdout and/or stderr are /dev/null, send warnings to the systemd Journal so they don't get lost, along with debug messages if enabled. - If the user requests it, redirect stdout and/or stderr to the systemd Journal so that everything will be logged in one place. - If stdout and/or stderr is already a Journal file descriptor inherited from a parent process, reopen it with our own details, and send our log messages with a bit more metadata. This obsoletes _srt_util_set_up_logging(), which did the first two of those. This is a per-application opt-in, because each application that will make use of this needs to be aware that it might redirect stdout and stderr. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
We can use this the same way GLib does: to detect that stdout or stderr is an inherited Journal stream, so that we can try to do our own Journal logging in preference to using that stream. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This does a few closely related things. If standard input, standard output and standard error are closed, we open them to point to /dev/null, and if they are close-on-exec, we clear their close-on-exec flags. This is to avoid weird side effects: most APIs like open() that create new file descriptors guarantee to use the lowest-numbered fd that is not already in use, but users of those APIs do not expect to be overwriting stdin/stdout/stderr. Because that operation can involve changing the meaning of stdout and stderr, we now optionally save a duplicate of the original standard output and standard error, so they can be put back later. Because we're now saving a duplicate of the original standard output and standard error, it also makes sense to implement SRT_LOG_FLAGS_DIVERT_STDOUT here. This avoids needing to call _srt_divert_stdout_to_stderr() separately in most callers. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
In some places, and especially in these logging functions, we can encounter situations that deserve a warning but should not result in program failure, even during unit testing or debugging with G_DEBUG=fatal-warnings. If _srt_log_failure() is like a non-fatal g_error(), then _srt_log_warning() is like a non-fatal g_warning(). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If we are going to write to the systemd Journal, we will want the program name to already be known, so that we can use it as the syslog identifier (first argument to sd_journal_stream_fd() and openlog()). This also reduces duplication a bit, and brings us one step closer to combining _srt_util_set_up_logging() with _srt_util_set_glib_log_handler(). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
launch-client: Print version number, --bus-name to original stdout See merge request !520
-
- Nov 16, 2022
-
-
Simon McVittie authored
These were intended to be written to the original stdout, but we didn't do that until after we'd already replaced stdout with stderr to avoid random diagnostic messages appearing on the original stdout. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Nov 15, 2022
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
In older chroot environments it's sometimes a symbolic link to /run/shm. Use /dev/pts as something that is more likely to be a real directory, and skip this part of the test if /dev/pts is somehow also a symlink. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
pv-locale-gen: Show a warning if we generated any locales See merge request !519
-
- Nov 14, 2022
-
-
Simon McVittie authored
This will give users a hint about how they can speed up container setup. Helps: https://github.com/ValveSoftware/steam-runtime/issues/541 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If we already know that we need to generate at least one locale, then testing more is a waste of time. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If we have detected a particular locale as missing, we only need to generate it once. This makes the script output a lot less repetitive, and speeds it up by about 30%. Fixes: e69ce85e "locale-gen: Add --output-dir option" Signed-off-by:
Simon McVittie <smcv@collabora.com>
-