Skip to content
Snippets Groups Projects
  1. Feb 09, 2024
  2. Jan 10, 2024
  3. Jan 09, 2024
  4. Dec 14, 2023
  5. Sep 18, 2023
  6. Aug 29, 2023
  7. Jul 28, 2023
  8. Mar 01, 2023
  9. Feb 27, 2023
  10. Nov 08, 2022
  11. Nov 01, 2022
  12. Oct 28, 2022
  13. Oct 10, 2022
  14. Aug 19, 2022
  15. Aug 01, 2022
  16. Jul 29, 2022
    • Jonathan Lebon's avatar
      fdio: fix fd offset handling with `FICLONE` · 7a2f26a3
      Jonathan Lebon authored
      When using `FICLONE`, the kernel does a full file clone and disregards the
      fd offsets. Users of this API however assume that it *is*
      offset-sensitive. So we need to verify that the fd offsets are at the
      start of the files before we call `FICLONE`. This was done in systemd also
      in:
      
      https://github.com/systemd/systemd/commit/c622fbdb8d37
      
      The commit message does not explain this but `ioctl_ficlone(2)` says:
      
          The `FICLONE` ioctl clones entire files.
      
      (Compare with `FICLONERANGE`, which takes a struct with offsets and the
      length).
      
      Similarly, we need to seek to the end of the file descriptors on success
      so that we're consistent with the behaviour of the other backends
      available (`copy_file_range`, `sendfile` and manual copying). This also
      matches what systemd does nowadays:
      
      https://github.com/systemd/systemd/blob/80f967311ac5/src/shared/copy.c#L199
      7a2f26a3
  17. Jul 27, 2022
    • Simon McVittie's avatar
      backports: Backport g_info() · c5e1b295
      Simon McVittie authored
      
      The rest of the g_log() wrappers have been there since time immemorial,
      but g_info() was initially omitted. It's useful for projects like Flatpak
      that want to have two levels of off-by-default logging, which map nicely
      to info and debug.
      
      Signed-off-by: default avatarSimon McVittie <smcv@collabora.com>
      c5e1b295
Loading