- Aug 30, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If we can't chmod the file, we should say what the current owner and permissions look like, to assist debugging. In particular, this is likely to happen on NTFS or when operating on a directory owned by a different user. For example, if the filesystem is owned by root (steam-runtime#544) we might say: Unable to change mode of ... from 0777 (owner: "root", group: "root", non-member) to 0644: ... or if the file is owned by the current user but the filesystem does not allow chmod anyway (steam-runtime#606) we might say: Unable to change mode of ... from 0755 (owner: current user, group: "users") to 0644: ... Helps: https://github.com/ValveSoftware/steam-runtime/issues/434 Helps: https://github.com/ValveSoftware/steam-runtime/issues/460 Helps: https://github.com/ValveSoftware/steam-runtime/issues/477 Helps: https://github.com/ValveSoftware/steam-runtime/issues/491 Helps: https://github.com/ValveSoftware/steam-runtime/issues/544 Helps: https://github.com/ValveSoftware/steam-runtime/issues/606 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
I'm going to extend this to cope better with filesystems where we do not own the files or otherwise cannot change their ownership, and that will be easier if we can early-return on success or if there is nothing to do. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If the filesystem or file ownership doesn't support setting the mtime, all of them will fail in the same way, leading to a lot of log-spam. In particular, this is likely to happen on NTFS or when operating on a directory owned by a different user. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This is just syntactic sugar for something we do quite often. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Fixes: b5441dc6 "pressure-vessel: Warn if we have to fall back to copying" Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Aug 24, 2023
-
-
Ludovico de Nittis authored
system-info: Check whether the Steam Runtime is on an unsupported filesystem See merge request !583
-
Simon McVittie authored
The preferred way to install all versions of the Steam Runtime, both LD_LIBRARY_PATH and container, is on a fully-featured local Unix filesystem such as ext4, btrfs or xfs. If that is not how it's installed, we should flag that in system-info reports so that we can treat it as a possible root cause for user-visible issues: as with many of our issue flags, it isn't *necessarily* a problem, but it's a *potential* problem. Ignore these issue flags during unit testing, because the filesystem we're running on during unit testing isn't under our control. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Aug 23, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Aug 17, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Aug 04, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Aug 02, 2023
-
-
Simon McVittie authored
Update libcapsule to v0.20230802.0 See merge request !576
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
flatpak-bwrap: Don't leak array of XDG_RUNTIME_DIR members See merge request !581
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Now that the tests pass on merged-/usr systems, we can use a more modern Debian suite. Normally I'd use the latest Debian stable (Debian 12), but that seems to have a false positive for a printf argument to %s being NULL, causing the asan/ubsan builds to fail; so use Debian 10 and 11 as our representatives of older systems, together with Debian 13 prereleases as our representative of a modern system. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Previously, we were assuming that the symlink created by capsule-capture-libs would point to the `realpath()` of a library, possibly with a `--link-target` prefix. However, it actually only resolves the symlink representing the SONAME: it will resolve `libz.so.1` to `libz.so.1.2.13`, but unlike Perl `abs_path()` or C `realpath()`, it will not necessarily resolve symlinks in the directory hierarchy leading up to that point. For example, on a merged-/usr system like Debian >= 12, /lib is a symbolic link to usr/lib. The realpath() of `libz.so.1` is something like `/usr/lib/MULTIARCH/libz.so.1.2.13`, but because both `/lib/MULTIARCH` and `/usr/lib/MULTIARCH` appear in `/etc/ld.so.conf.d`, it is undefined whether capsule-capture-libs will output `/lib/MULTIARCH/libz.so.1.2.13` or `/usr/lib/MULTIARCH/libz.so.1.2.13`. Relax the expectations of this test so we only say that the symlink points to some reasonable `$libdir`, followed by the `basename()` of the `realpath()` of `libc.so.6`. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
`warn(fmt, args)` is equivalent to (pseudocode) `warnx(fmt + ": %s", args, strerror(errno))`. In contexts where we do not have a useful value for errno, or where we are showing an error message that should already contain a previous result of strerror, we should use warnx() instead. This avoids showing a misleading errno which might have been set for some unrelated reason. Prompted by jupiter/tasks#887. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
Fix several memory leaks See merge request !580
-
- Aug 01, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
glibc searches /lib:/usr/lib as a hard-coded fallback, but we don't expect to get there when searching for dependencies in practice: on OSs that have dedicated 32- and 64-bit directories (such as Red-Hat-style multilib, Arch-style multilib and Debian-style multiarch), those directories are searched indirectly as part of ld.so.cache. Mentioning that this is a fallback makes it a little bit more obvious that it isn't an error that we were not searching /usr/lib32, /usr/lib64 or /usr/lib/MULTIARCH when looking for a library of the appropriate word size. While I'm here, deduplicate the end of the message a bit. Suggested-by: Emil Velikov Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This reverts commit 1982a2d4.
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
In each case we weren't freeing the result of json_object_get_members(), which is `(transfer container)`. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
utils: Run timeout(1) with short options See merge request !579
-
Simon McVittie authored
If one of these happens, then something odd is going on and we should diagnose it. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This avoids having to turn on noisier options that CAPSULE_DEBUG=tool to see this. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Debian 9 is way past end-of-life and has now been removed from the main Debian mirrors, causing CI to fail. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Some operating system distributions use busybox sh or busybox timeout, which doesn't support GNU long options. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jul 28, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-