Skip to content
Snippets Groups Projects
  1. Jul 31, 2017
  2. Jul 26, 2017
  3. Jul 24, 2017
  4. Jul 21, 2017
    • Jonathan Lebon's avatar
      errors: check for an error before prefixing · c820571b
      Jonathan Lebon authored
      Minor tweak to the new `GLNX_AUTO_PREFIX_ERROR`. Since the common case
      is that there's no errors, let's bring down the same check that
      `g_prefix_error` does to avoid a function call most of the time.
      c820571b
  5. Jul 20, 2017
  6. Jul 19, 2017
  7. Jul 17, 2017
    • Colin Walters's avatar
      errors: Add GLNX_AUTO_PREFIX_ERROR · 607f1775
      Colin Walters authored
      In a lot of places in ostree, we end up prefixing errors in the *caller*.
      Often we only have 1-2 callers, and doing the error prefixing isn't
      too duplicative.  But there are definitely cases where it's cleaner
      to do the prefixing in the callee.  We have functions that aren't
      ported to new style for this reason (they still do the prefixing
      in `out:`).
      
      Introduce a cleanup-oriented version of error prefixing so we can port those
      functions too.
      607f1775
    • Colin Walters's avatar
      fdio: Add string prefix for glnx_fstat() · 61ef326a
      Colin Walters authored
      For consistency.
      61ef326a
    • Colin Walters's avatar
      fdio: Add a fchmod wrapper · 547bcea2
      Colin Walters authored
      There are a number of versions of this in ostree at least, might as well wrap
      it.
      547bcea2
    • Colin Walters's avatar
      Remove glnx_stream_fstat() · 8b75c8e3
      Colin Walters authored
      There are only two users of this in ostree, and one of them is
      fairly bogus; we can just use `fstat()`.
      8b75c8e3
    • Colin Walters's avatar
      fdio: Add cleanup+flush API for FILE* · e30a773f
      Colin Walters authored
      Mostly in ostree/rpm-ostree, we work in either raw `int fd`, or
      `G{Input,Output}Stream`.  One exception is the rpm-ostree `/etc/passwd`
      handling, which uses `FILE*` since that's what glibc exposes.
      
      And in general, there are use cases for `FILE*`; the raw `GUnixOutputStream` for
      example isn't buffered, and doing so via e.g. `GBufferedOutputStream` means
      allocating *two* GObjects and even worse going through multiple vfuncs for every
      write.
      
      `FILE*` is used heavily in systemd, and provides buffering. It is a bit cheaper
      than gobjects, but has its own trap; by default every operation locks a mutex.
      For more information on that, see `unlocked_stdio(3)`. However, callers can
      avoid that by using e.g. `fwrite_unlocked`, which I plan to do for most users of
      `FILE*` that aren't writing to one of the standard streams like `stdout` etc.
      e30a773f
  8. Jul 13, 2017
  9. Jul 10, 2017
  10. Jun 30, 2017
  11. Jun 28, 2017
  12. Jun 26, 2017
  13. Jun 17, 2017
  14. Jun 14, 2017
    • Colin Walters's avatar
      Add G_IN_SET, patch our internal users via spatch · 9a1b77ef
      Colin Walters authored
      I originally tried to get this into GLib:
      https://bugzilla.gnome.org/show_bug.cgi?id=783751
      
      But that looks like it's going to fail due to MSVC. Let's add it here at least
      so I can start using it tomorrow and not wait for the MSVC team to catch up.
      
      I renamed `glnx-alloca.h` to `glnx-macros.h` as a more natural collective
      home for things from systemd's `macro.h`.
      
      Finally, I used a Coccinelle spatch similar to the one referenced
      in the above BZ to patch our uses.
      9a1b77ef
  15. Jun 13, 2017
  16. May 31, 2017
    • Colin Walters's avatar
      dirfd: Have dfd iter _take_fd() take a pointer and do a steal · f5ba01cf
      Colin Walters authored
      This avoids callers having to use `glnx_steal_fd()` on their own; in general, I
      think we should implement move semantics like this at the callee level.
      
      Another reason to do this is there's a subtle problem with doing:
      
      ```
      somefunction (steal_value (&v), ..., error);
      ```
      
      in that if `somefunction` throws, it may not have taken ownership of the value.
      At least `glnx_dirfd_iterator_init_take_fd()` didn't.
      f5ba01cf
  17. May 30, 2017
  18. May 19, 2017
  19. May 17, 2017
  20. May 15, 2017
    • Colin Walters's avatar
      fdio: Redo tmpfile API with GLnxTmpfile struct · 9929adcd
      Colin Walters authored
      The core problem with the previous tmpfile code
      is we don't have an autocleanup that calls `unlinkat`
      in the non-`O_TMPFILE` case.  And even if we did, it'd
      be awkward still since the `glnx_link_tmpfile_at()` call
      *consumes* the tmpfile.
      
      Fix this by introducing a struct with a cleanup macro. This simplifies a number
      of the callers in libostree - a notable case is where we had two arrays, one of
      fds, one of paths. It makes other places in libostree a bit more complex, but
      that's because some of the commit code paths want to deal with temporary
      *symlinks* too.
      
      Most callers are better though - in libglnx itself, `glnx_file_copy_at()` now
      correctly unlinks on failure for example.
      9929adcd
  21. May 11, 2017
  22. Apr 28, 2017
    • Colin Walters's avatar
      fdio: Expose glnx_regfile_copy_bytes(), rewrite: GNU style, POSIX errno · 3a4d0f46
      Colin Walters authored
      NOTE: This changes the error handling API of `glnx_loop_write()` to be
      "old school POSIX" instead of "systemd".
      
      In ostree in a few places we use `g_output_stream_splice()`.  I
      thought this would use `splice()`, but actually it doesn't today.
      
      They also, if a cancellable is provided, end up dropping into `poll()` for every
      read and write. (In addition to copying data to/from userspace).
      
      My opinion on this is - for *local files* that's dumb. In the big picture, you
      really only need cancellation when copying gigabytes. Down the line, we could
      perhaps add a `glnx_copy_bytes_cancellable()` that only did that check e.g.
      every gigabyte of copied data. And when we do that we should use
      `g_cancellable_set_error_if_cancelled()` rather than a `poll()` with the regular
      file FD, since regular files are *always* readable and writable.
      
      For my use case with rpm-ostree though, we don't have gigabyte sized files, and
      seeing all of the `poll()` calls in strace is annoying. So let's have the
      non-cancellable file copying API that's modern and uses both reflink and
      `sendfile()` if available, in that order.
      
      My plan at some point once this is tested more is to migrate this code
      into GLib.
      
      Note that in order to keep our APIs consistent, I switched the systemd-imported
      code to "old school POSIX" error conventions. Otherwise we'd have *3* (POSIX,
      systemd, and GError) and particularly given the first two are easily confused,
      it'd be a recipe for bugs.
      3a4d0f46
  23. Apr 25, 2017
    • Colin Walters's avatar
      fdio: Mostly port to new code style · dc1956b2
      Colin Walters authored
      There's one function that did `unlinkat()` in the cleanup section,
      not doing that yet.
      
      Note I uncovered a few bugs in a few places where we didn't preserve errno
      before doing an `unlinkat()` in error paths in a few cases.
      
      I also tried to prefix a few more error cases with the system call name.
      dc1956b2
    • Colin Walters's avatar
      Port most code (except fdio) to new style · 47fafa97
      Colin Walters authored
      There's a lot more fdio code, starting with some of the easier ones.
      47fafa97
  24. Apr 21, 2017
Loading