- Jan 30, 2023
-
-
Simon McVittie authored
CI: Run the old SteamLinuxRuntime CI tests in the subproject See merge request !532
-
Simon McVittie authored
runtime: Fix path_visible_in_provider_namespace() check Closes tasks#213 See merge request !531
-
Ludovico de Nittis authored
The check to ensure that the path had the prefix `sbin` was wrongly using the OR comparison instead of the AND. This meant that `path_visible_in_provider_namespace()` was returning true for every path that was under a 4 characters long directory. E.g. `home/[...]` was unexpectedly considered to be visible in the provider namespace. This check is used in `pv_runtime_take_from_provider()` to evaluate if a simple symlink would be enough or if instead the files should be copied in a directory that is visible from inside the container. Leading to possible unexpected dangling symlinks. Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
- Jan 26, 2023
-
-
Simon McVittie authored
This is almost certainly redundant with some of what we do in pressure-vessel, but it's a step towards fully integrating the subproject. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jan 24, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This makes these scripts a better template to drop into other projects. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This avoids warnings from newer versions of Meson. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jan 12, 2023
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
Avoid #!/usr/bin/env bash scripts See merge request !530
-
- Jan 10, 2023
-
-
Simon McVittie authored
Because this script runs inside the SteamLinuxRuntime_soldier container, we don't need to worry about whether /bin/bash exists or makes sense: we know that it should be the bash from Debian 10, which is what this script was written to target. Use it by its absolute path instead of doing a PATH search, to add a bit more predictability. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
These scripts don't use any fancy features from bash, so we can use /bin/sh, which is either bash or something faster (like the dash shell used in Debian and Ubuntu). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
We are no longer supporting any pressure-vessel releases that didn't. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
bash is not completely portable, so we have to stick to POSIX /bin/sh, which only has one array, "$@". Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
bash is not completely portable, so we have to stick to POSIX /bin/sh, which only has one array, "$@". Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This is a prerequisite for converting this script to /bin/sh, because this sort of argument vector manipulation would be difficult to do while preserving relative order without access to more than one array. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This is a prerequisite for converting this script to /bin/sh, because this sort of argument vector manipulation would be difficult to do while preserving relative order without access to more than one array. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Using bash for a shell script is apparently not entirely portable, because #!/bin/bash is not available on some unconventional OSs like NixOS, while the frequently-recommended alternative #!/usr/bin/env bash might find an unusable version of bash in the PATH. In particular, if the bash in the PATH was installed via Nix, then it relies on RUNPATH for correct operation, but the scout runtime's LD_LIBRARY_PATH defeats that. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This makes it easier to set them up in the wrapper shell scripts without making use of bash-specific features, which are not completely portable. For LD_PRELOAD, the separator is either a colon or a space; for LD_AUDIT, the separator is a colon. There is no facility for escaping the separators. This matches the behaviour of the environment variables in glibc ld.so, as implemented in elf/rtld.c. The usual reason to prefer separate command-line arguments over parsing is that a single merged argument either requires an escape mechanism or cannot represent certain data (for instance loadable modules with a colon in their filenames), but there is no need to try to support things that glibc doesn't, and glibc doesn't support loadable modules with the separator in their filenames anyway. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Parse ELF header for version definitions Closes #95 See merge request !529
-
- Jan 05, 2023
-
-
Ludovico de Nittis authored
Parse the new `missing_versions` and `unexpectedly_unversioned` issues that `inspect-library` could report. Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
Ludovico de Nittis authored
Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
Ludovico de Nittis authored
If in the `.symbols` file there is a verdef `$VERSION@$VERSION`, we can manually parse the ELF header to check if the library has the expected `$VERSION` or not. All missing versions will be reported in output in a list called `missing_versions`. If the library is unexpectedly unversioned, the `unexpectedly_unversioned` entry will be set to `true`. Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
- Jan 04, 2023
-
-
Ludovico de Nittis authored
Move the common print operation in a separate function to reduce code duplication. Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
- Dec 15, 2022
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If we're using a local or pre-downloaded pressure-vessel-bin.tar.gz, there's no point in trying to download the scout LD_LIBRARY_PATH runtime (for automated testing) from a suite named "local" that doesn't exist. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 14, 2022
-
-
Simon McVittie authored
This allows populate-depot.py to learn its own version number when used by unpacking a steam-runtime-tools source tarball, rather than from git, and write that into VERSIONS.txt as the "scripts" component. Now that we've combined SteamLinuxRuntime and s-r-t into one repository, the "scripts" component is somewhat redundant for the soldier and sniper runtimes (since it will always match up with pressure-vessel), but it's still interesting for the scout-on-soldier runtime (which does not contain its own copy of pressure-vessel). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
We also write this into subprojects/container-runtime so that populate-depot.py can find it there. This will enable populate-depot.py to learn its own version number when used by unpacking a steam-runtime-tools source tarball, rather than from git. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Dec 08, 2022
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-