- Jul 29, 2019
-
-
Simon McVittie authored
In the real GLib version, constructs like g_clear_pointer (&hash, g_hash_table_unref) are allowed, and do not provoke warnings. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
inspect-library: Remove dead code from command-line parsing Closes #4 See merge request steam/steam-runtime-tools!22
-
Simon McVittie authored
Closes: #4 Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
inspect-library: Add support for consuming deb-symbols(5) files See merge request steam/steam-runtime-tools!21
-
- Jul 26, 2019
-
-
Simon McVittie authored
The Steam Runtime is built using dpkg/apt, so we have this information already for a lot of the shared libraries, for example in `/var/lib/dpkg/info/zlib1g:amd64.symbols` in a SDK container. For those that we don't, such as libcurl3, we can generate a deb-symbols(5) file by either improving the packaging, or using for example dpkg-gensymbols -q -v0 -plibcurl3 -e/usr/lib/x86_64-linux-gnu/libcurl.so.3 -I/dev/null -O (although the output of such commands will require some postprocessing and common sense to filter out private symbols that are not meant to be part of the ABI). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Previously, we would have accepted this as not a parse error, and then crashed with strcmp(NULL, ...) when we tried to use it. It obviously ought to mean the same thing as @Base, so treat it the same. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
There's no point in freeing the buffer every time: getline() is designed to reuse it. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
We were relying on the fact that strsep(&line, ...) resets line to NULL when it reaches the end, which is not at all obvious. Swap the roles of the variables around. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
inspect-library: Treat "-" as meaning stdin See merge request steam/steam-runtime-tools!19
-
Simon McVittie authored
To test: echo "foo@Base" | ./_build/helpers/x86_64-linux-gnu-inspect-library libz.so.1 - This isn't used for anything yet, but when we give it more integration into the library, we might want to use a pipe to supply the list of symbols. For instance, if we use deb-symbols(5) symbols lists (which describe one or more shared libraries, each with their symbols) to describe the Steam Runtime, then we'll want something like this pseudocode: while lines remain: SONAME = next line until first whitespace run helper with pipes on stdin and stdout while next line starts with one of ('|', '*', ' '): if next line starts with ' ': symbol@version = rest of line until first whitespace write symbol@version to pipe else: ignore '* Field: value' or '| alternative dependency' close pipe to helper's stdin collect results from stdout collect exit status add SrtLibrary to list of libraries Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Ludovico de Nittis authored
Add inspect-library helper See merge request steam/steam-runtime-tools!2
-
Ludovico de Nittis authored
This helper takes a SONAME as an argument, and optionally a filename for symbols, and outputs a parsable JSON with the path, the dependencies and the possible missing symbols of the requested library. Signed-off-by:
Ludovico de Nittis <ludovico.denittis@collabora.com>
-
Ludovico de Nittis authored
build: Disable -Wunused-local-typedefs See merge request steam/steam-runtime-tools!18
-
Ludovico de Nittis authored
utils: Ensure that g_type_init() gets called See merge request steam/steam-runtime-tools!16
-
Ludovico de Nittis authored
build: Allow C99 constructs See merge request steam/steam-runtime-tools!17
-
- Jul 25, 2019
-
-
Simon McVittie authored
In older versions of GLib, G_STATIC_ASSERT triggers this. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This is the default in newer compilers, but not in Steam Runtime 1 'scout'. Many GLib projects are stuck on C89 anyway because they care about Microsoft Visual Studio's C compiler, but this project is Linux-only code so we can rely on C99. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
In GLib < 2.36, this wasn't automatic. The constructor has been backported into the SteamRT 1 'scout' version of GLib, but if you have an environment with more Ubuntu 12.04 apt sources available (like the official SDK schroot from setup_chroot.sh), they might override the SteamRT-patched version. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jul 24, 2019
-
-
Simon McVittie authored
Add Gitlab-CI See merge request steam/steam-runtime-tools!10
-
Simon McVittie authored
We are targeting scout, but because scout is so old, its SDK environment is too old to run deb-build-snapshot. Instead, we do that step in a Debian 10 'buster' environment, and hand over the artifacts from that to the autopkgtest step. Our build-dependencies are not all preinstalled in the CI Docker images, so add them. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
If gnome-desktop-testing isn't available, we want to treat that as though this test had been skipped, rather than as though it had failed. d/tests/run effectively duplicates it anyway. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
tests/test-library uses g_assert_nonnull(), which isn't available in SteamRT 1 'scout'. While I'm here, add all the other assertion wrappers from GLib 2.58 that aren't available in 2.32 (except for the rather niche g_assert_cmpfloat_with_epsilon()), along with g_test_skip(). Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Fix handling of enums.h See merge request steam/steam-runtime-tools!13
-
Simon McVittie authored
_srt_get_helpers_path: If in /lib, assume helpers are in /usr/libexec See merge request steam/steam-runtime-tools!14
-
- Jul 23, 2019
-
-
Simon McVittie authored
On a system with merged-/usr, steam-runtime-tools might be installed in /usr/lib/MULTIARCH (or /usr/lib64 or /lib64) but found via the /lib -> usr/lib or /lib64 -> usr/lib64 symlink. /libexec doesn't normally exist, so look for the helpers in /usr/libexec instead. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
With this change, the 'build' autopkgtest would have detected the bug. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Don't build gtk-doc documentation if gtk-doc is too old See merge request steam/steam-runtime-tools!12
-
- Jul 22, 2019
-
-
Simon McVittie authored
The gtk-doc in scout doesn't understand --cflags. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jul 19, 2019
-
-
Simon McVittie authored
Adjust code that libsteam-runtime-tools uses to find itself See merge request steam/steam-runtime-tools!9
-
Simon McVittie authored
Add a script to wrap tests with valgrind See merge request steam/steam-runtime-tools!8
-
- Jul 18, 2019
-
-
Simon McVittie authored
This should make it easier to find memory leaks in future. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Add a skeleton for SrtLibrary, representing a shared library See merge request steam/steam-runtime-tools!7
-
Simon McVittie authored
Only remove a /lib/CPU-linux-gnu suffix (not just /CPU-linux-gnu), and handle a /lib64 suffix the same as /lib. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
This avoids relying on the implementation detail of knowing what the shared library ought to be called. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jul 17, 2019
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- Jul 16, 2019
-
-
Simon McVittie authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-