Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
steam-runtime-tools
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
steamrt
steam-runtime-tools
Commits
a9fa948c
Commit
a9fa948c
authored
5 years ago
by
Simon McVittie
Browse files
Options
Downloads
Patches
Plain Diff
Remove "unshare home" from GUI launcher to manage expectations
Signed-off-by:
Simon McVittie
<
smcv@collabora.com
>
parent
b78f9751
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
README.md
+5
-5
5 additions, 5 deletions
README.md
pressure-vessel-test-ui
+14
-7
14 additions, 7 deletions
pressure-vessel-test-ui
with
19 additions
and
12 deletions
README.md
+
5
−
5
View file @
a9fa948c
...
...
@@ -76,6 +76,8 @@ newer libstdc++. This is not yet implemented.
### Protecting `$HOME`
(This feature is not being actively developed right now.)
If we change the meaning of
`/home`
for a game to be a fake
app-specific directory, then the game can't write random files in unknown
subdirectories of $HOME, and we can be reasonably sure that uninstalling
...
...
@@ -435,11 +437,7 @@ interactive shell).
- `--steam-app-id=70 --unshare-home` (when running from Steam you can use
`--steam-app-id=${SteamAppId}`, which is the default)
Unchecking "Share real home directory" in the GUI launcher is the
same as `--unshare-home` on the command-line. It is an error to do
this without telling `pressure-vessel-wrap` what to use for the home
directory, either via `--fake-home`, `--freedesktop-app-id`,
`--steam-app-id`, or having the `SteamAppId` environment variable.
This feature is not being actively developed right now.
Steam integration
-----------------
...
...
@@ -548,6 +546,8 @@ increasingly long "adverb" command around the command to be run.
### Unsharing the home directory
(This feature is not being actively developed right now.)
Each game gets a private home directory in
`~/.var/app`
, the same as
Flatpak apps do. The name of the private home directory follows the
[
naming recommendations from the freedesktop.org Desktop Entry
...
...
This diff is collapsed.
Click to expand it.
pressure-vessel-test-ui
+
14
−
7
View file @
a9fa948c
...
...
@@ -43,6 +43,10 @@ from gi.repository import Gtk
logger
=
logging
.
getLogger
(
'
pressure-vessel-test-ui
'
)
# This doesn't fully work yet. Hack at own risk.
CAN_UNSHARE_HOME
=
False
class
Gui
:
def
__init__
(
self
):
# type: (...) -> None
...
...
@@ -104,13 +108,16 @@ class Gui:
row
+=
1
self
.
share_home_check
=
Gtk
.
CheckButton
.
new_with_label
(
'
Share real home directory
'
)
self
.
share_home_check
.
set_active
(
True
)
self
.
grid
.
attach
(
self
.
share_home_check
,
1
,
row
,
1
,
1
)
if
CAN_UNSHARE_HOME
:
self
.
share_home_check
=
Gtk
.
CheckButton
.
new_with_label
(
'
Share real home directory
'
)
self
.
share_home_check
.
set_active
(
True
)
self
.
grid
.
attach
(
self
.
share_home_check
,
1
,
row
,
1
,
1
)
row
+=
1
row
+=
1
else
:
self
.
share_home_check
=
None
self
.
xterm_check
=
Gtk
.
CheckButton
.
new_with_label
(
'
Run in an xterm
'
)
self
.
xterm_check
.
set_active
(
False
)
...
...
@@ -255,7 +262,7 @@ class Gui:
argv
.
append
(
'
--runtime
'
)
argv
.
append
(
os
.
path
.
join
(
id
,
'
files
'
))
if
self
.
share_home_check
.
get_active
():
if
self
.
share_home_check
is
None
or
self
.
share_home_check
.
get_active
():
argv
.
append
(
'
--share-home
'
)
else
:
argv
.
append
(
'
--unshare-home
'
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment