Skip to content
Snippets Groups Projects
Commit 76995e52 authored by Simon McVittie's avatar Simon McVittie
Browse files

wrap-setup test: Stop asserting that "/" is marked as exported


This makes no sense: the comment above indicates that we *didn't* want
this path to be exported, and if it was exported then we would be
unable to have any control over the filesystem namespace.

In fact, it is not exported: the fact that it appears to be exported
is an implementation quirk of flatpak_exports_path_get_mode(),
which returns FLATPAK_FILESYSTEM_MODE_READ_WRITE because none of the
zero remaining path segments is unmapped.

Signed-off-by: default avatarSimon McVittie <smcv@collabora.com>
parent 8ba3b8d6
No related branches found
No related tags found
1 merge request!785Export parent directory of LD_PRELOAD modules
...@@ -1885,10 +1885,6 @@ test_remap_ld_preload (Fixture *f, ...@@ -1885,10 +1885,6 @@ test_remap_ld_preload (Fixture *f,
/* We don't know what ${FUTURE} will expand to, so we have to cut off at /* We don't know what ${FUTURE} will expand to, so we have to cut off at
* /future */ * /future */
g_assert_true (flatpak_exports_path_is_visible (exports, "/future")); g_assert_true (flatpak_exports_path_is_visible (exports, "/future"));
/* We don't export the entire root directory just because it has a
* module in it */
g_assert_true (flatpak_exports_path_is_visible (exports, "/"));
} }
static void static void
...@@ -2020,10 +2016,6 @@ test_remap_ld_preload_no_runtime (Fixture *f, ...@@ -2020,10 +2016,6 @@ test_remap_ld_preload_no_runtime (Fixture *f,
/* We don't know what ${FUTURE} will expand to, so we have to cut off at /* We don't know what ${FUTURE} will expand to, so we have to cut off at
* /future */ * /future */
g_assert_true (flatpak_exports_path_is_visible (exports, "/future")); g_assert_true (flatpak_exports_path_is_visible (exports, "/future"));
/* We don't export the entire root directory just because it has a
* module in it */
g_assert_true (flatpak_exports_path_is_visible (exports, "/"));
} }
static void static void
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment