Install AFDKO in the image
Cc: @smcv
Would it be okay to install afdko through pip
in the image? Something like this:
diff --git a/docker/proton.Dockerfile.in b/docker/proton.Dockerfile.in
index d3845d2..84ff756 100644
--- a/docker/proton.Dockerfile.in
+++ b/docker/proton.Dockerfile.in
@@ -57,9 +57,13 @@ RUN apt-get install -y \
python3-pefile \
libcapstone-dev \
libcapstone-dev:i386 \
+ python3-pip \
&& rm -rf /opt/usr/share/doc /opt/usr/share/info /opt/usr/share/man \
&& rm -rf /var/lib/apt/lists/*
+RUN pip3 install afdko
+
ENTRYPOINT ["/usr/bin/tini-static", "-s", "-g", "--"]
CMD ["/bin/bash"]
Alternatively would it be possible to port afdko to soldier?
This (+ fontforge, which is already packaged) is used during Proton's build and is executed on the host. I would like to move that step to the container to require fewer deps on the host side and make the experience more consistent - there are quite a few gotchas depending how afdko was installed (pip vs distro packages).
[Tracked as T28554 internally —smcv]
Edited by Simon McVittie