Skip to content

Fix regression during CI testing of the SDK sysroot

Simon McVittie requested to merge wip/smcv/ci into main
  • tests: Test the SDK sysroot in CI, even for non-protected branches

    This is a feature that we document for game developers: the ability to launch a game in a SDK sysroot that comes with debugging tools preinstalled, and can be altered by the developer to insert more debugging tools or patched libraries if they want to.

    steamrt/tasks#448

  • populate-depot: Don't unlink an empty list of files

    At this point we haven't populated the list yet, so this stanza has no practical effect.

    Fixes: d78e1bbe "populate-depot: Rename files with multiple links or problematic names"

  • populate-depot: Don't unlink empty files and symlinks from SDK sysroot

    When we're minimizing the Platform runtime, we want to delete any file that is fully represented by its entry in the mtree, but when we're generating the top-level mtree, we can't do that: if there was an empty file or symlink that's functionally necessary to run pressure-vessel, we have to preserve it, so that we can run pressure-vessel and reconstitute the Platform from the mtree manifest.

    This was particularly bad for the non-default option that adds a SDK sysroot to the container runtime, which we don't do in production but we do use during CI.

    steamrt/tasks#448

    Fixes: d78e1bbe "populate-depot: Rename files with multiple links or problematic names"

  • populate-depot: Rename can_rename_files parameter to minimize

    This is more general than "can rename files": it also determines whether we can delete files that we will be able to reconstitute fully from the mtree manifest.


/cc @denittis @refi64

Edited by Simon McVittie

Merge request reports