From c2dbe1811bc5a0176d7df8280625220681a60011 Mon Sep 17 00:00:00 2001 From: "Owen W. Taylor" <otaylor@fishsoup.net> Date: Fri, 30 Nov 2018 16:22:51 -0500 Subject: [PATCH] Fix docs for glnx_file_replace_contents() The docs for `glnx_file_replace_contents[_with_perms]` say that the default mode is 0666 - umask, but it's actually 0644. Because there's no thread-safe way of finding out the current umask without grubbing around in /proc/self/status, simply make the docs reflect reality. --- glnx-fdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/glnx-fdio.c b/glnx-fdio.c index a1f19037a..7b734ff6f 100644 --- a/glnx-fdio.c +++ b/glnx-fdio.c @@ -1002,8 +1002,7 @@ glnx_file_copy_at (int src_dfd, * contents. This and other behavior can be controlled via @flags. * * Note that no metadata from the existing file is preserved, such as - * uid/gid or extended attributes. The default mode will be `0666`, - * modified by umask. + * uid/gid or extended attributes. The default mode will be `0644`. */ gboolean glnx_file_replace_contents_at (int dfd, @@ -1025,7 +1024,7 @@ glnx_file_replace_contents_at (int dfd, * @subpath: Subpath * @buf: (array len=len) (element-type guint8): File contents * @len: Length (if `-1`, assume @buf is `NUL` terminated) - * @mode: File mode; if `-1`, use `0666 - umask` + * @mode: File mode; if `-1`, use `0644` * @flags: Flags * @cancellable: Cancellable * @error: Error -- GitLab