From 704f85a70714c135cce01a87d1faaf62280a4da2 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@collabora.com>
Date: Fri, 17 May 2019 12:07:06 +0100
Subject: [PATCH] Correct sense of error detection for symlink() syscalls

Signed-off-by: Simon McVittie <smcv@collabora.com>
---
 src/wrap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/wrap.c b/src/wrap.c
index 0134b04b7..2a3c16036 100644
--- a/src/wrap.c
+++ b/src/wrap.c
@@ -1254,7 +1254,7 @@ use_fake_home (FlatpakBwrap *bwrap,
     {
       g_unlink (cache2);
 
-      if (!symlink (".cache", cache2))
+      if (symlink (".cache", cache2) != 0)
         return glnx_throw_errno_prefix (error,
                                         "Unable to create symlink %s -> .cache",
                                         cache2);
@@ -1264,7 +1264,7 @@ use_fake_home (FlatpakBwrap *bwrap,
     {
       g_unlink (config2);
 
-      if (!symlink (".config", config2))
+      if (symlink (".config", config2) != 0)
         return glnx_throw_errno_prefix (error,
                                         "Unable to create symlink %s -> .config",
                                         config2);
@@ -1274,7 +1274,7 @@ use_fake_home (FlatpakBwrap *bwrap,
     {
       g_unlink (data2);
 
-      if (!symlink (".local/share", data2))
+      if (symlink (".local/share", data2) != 0)
         return glnx_throw_errno_prefix (error,
                                         "Unable to create symlink %s -> .local/share",
                                         data2);
-- 
GitLab