From 0773f4ed4c64dbaf0130240c50ed9d867907b5ef Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@collabora.com>
Date: Wed, 28 Jul 2021 18:34:14 +0100
Subject: [PATCH] tests: Add test coverage for passing incorrect options to
 pv-adverb

Signed-off-by: Simon McVittie <smcv@collabora.com>
---
 tests/pressure-vessel/adverb.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tests/pressure-vessel/adverb.py b/tests/pressure-vessel/adverb.py
index 4b466ac88..a7ea5c8af 100755
--- a/tests/pressure-vessel/adverb.py
+++ b/tests/pressure-vessel/adverb.py
@@ -27,6 +27,9 @@ from testutils import (
 logger = logging.getLogger('test-adverb')
 
 
+EX_USAGE = 64
+
+
 class TestAdverb(BaseTest):
     def run_subprocess(
         self,
@@ -211,6 +214,26 @@ class TestAdverb(BaseTest):
             proc.wait()
             self.assertEqual(proc.returncode, 0)
 
+    def test_wrong_options(self) -> None:
+        for option in (
+            '--an-unknown-option',
+            '--pass-fd=-1',
+            '--shell=wrong',
+            '--terminal=wrong',
+        ):
+            proc = subprocess.Popen(
+                self.adverb + [
+                    option,
+                    '--',
+                    'sh', '-euc', 'exit 42',
+                ],
+                stdout=2,
+                stderr=2,
+                universal_newlines=True,
+            )
+            proc.wait()
+            self.assertEqual(proc.returncode, EX_USAGE)
+
     def tearDown(self) -> None:
         super().tearDown()
 
-- 
GitLab