From d411a33b52643f65b5ff3776cca2dcc6dc26a93c Mon Sep 17 00:00:00 2001
From: Jeremy Whiting <jeremy.whiting@collabora.com>
Date: Wed, 30 Mar 2022 08:57:47 -0600
Subject: [PATCH] Use NamedTemporaryFile instead of mkstemp.

---
 src/steamos-devkit-service.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/steamos-devkit-service.py b/src/steamos-devkit-service.py
index 5ddbf69..b103ee2 100644
--- a/src/steamos-devkit-service.py
+++ b/src/steamos-devkit-service.py
@@ -62,15 +62,11 @@ def write_file(data: bytes) -> str:
     Return the empty string if unable to open temp file for some reason
     """
 
-    # Get 1 from the resulting tuple, since that's the filename
-    filename = tempfile.mkstemp(prefix="devkit-", dir="/tmp/", text=True)[1]
-
-    # Then open ourselves
-    with open(filename, "w", encoding='utf-8') as file:
+    with tempfile.NamedTemporaryFile(mode='w', prefix='devkit-1', encoding='utf-8',
+        delete=False) as file:
         file.write(data.decode())
-        file.close()
 
-        return filename
+        return file.name
 
     return ''
 
-- 
GitLab